Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformer Plugin #1520

Closed
wants to merge 5 commits into from
Closed

Conversation

PeteMichaud
Copy link

In reference to issue #1509, I wrote an implementation of the Transformer plugins as described in that issue and implemented in https://github.com/PeteMichaud/jekyllpedia/blob/master/_plugins/jekyllpedia.rb (Note: the jekyllpedia thing is only meant as an API reference, the implementation is broken in like 6 ways that I can see off the top of my head, don't use it until I actually write it correctly).

I opted to Transform prior to the liquid conversion (see https://github.com/PeteMichaud/jekyll/compare/transformer#L1R139), because I thought that was probably more powerful than the other way around. Now Transformers can potentially inject or alter the liquid code before that code is rendered to a final page.

@PeteMichaud
Copy link
Author

Do I need to change things for it to be accepted? Are we waiting until next release cycle to merge this since it's a new feature, or what's the deal? I'd like to stay using the main line of jekyll, but I really need this functionality, so if I could get an idea of if and when this might be accepted and make it into rubygems that would be awesome.

Anything I can do to make this better or to help in any way, let me know.

@mattr-
Copy link
Member

mattr- commented Sep 28, 2013

We're still looking at this. We're just really slow sometimes.

On Fri, Sep 27, 2013 at 7:45 PM, Pete Michaud notifications@github.com
wrote:

Do I need to change things for it to be accepted? Are we waiting until next release cycle to merge this since it's a new feature, or what's the deal? I'd like to stay using the main line of jekyll, but I really need this functionality, so if I could get an idea of if and when this might be accepted and make it into rubygems that would be awesome.

Anything I can do to make this better or to help in any way, let me know.

Reply to this email directly or view it on GitHub:
#1520 (comment)

@PeteMichaud
Copy link
Author

I understand @mattr- thanks for the update 8)

@parkr parkr closed this Mar 17, 2014
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants